Repository navigation
Pass the response getter into nested model types that own an active field - #2330
Open
jar-stripe wants to merge 2 commits into
Open
jar-stripe wants to merge 2 commits into
jar-stripe wants to merge 2 commits into
Conversation
…ve field Customer.InvoiceSettings and the same shape elsewhere extended plain StripeObject with no way to receive or propagate a StripeResponseGetter. If such a type owns an expandable field, or a field whose own type does, the expanded object's instance methods silently fell back to the process-global client/key instead of the client that retrieved it. Generated from stripe/sdk-codegen#4350. RUN_DEVSDK-3696 Committed-By-Agent: claude
jar-stripe
changed the title
jar-stripe
marked this pull request as ready for review
November 7, 2026 05:06
jar-stripe
requested review from
mnorth-stripe
and removed request for
a team
November 7, 2026 05:06
jar-stripe
enabled auto-merge (squash)
November 7, 2026 05:46
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Customer.InvoiceSettingsand other nested, non-resource types extended plainStripeObjectwith no way to receive or propagate aStripeResponseGetter. If such a type owns an expandable field, or a field whose own type does, the expanded object's instance methods silently fell back to the process-global client/key instead of the client that retrieved it. The generator now gives any type that owns an active field, resource or not, theStripeActiveObjectinterface and a propagatingsetResponseGetteroverride.What?
Customer.InvoiceSettings,Charge.Outcome,ConnectCollectionTransfer) viajust gen javaagainst the sdk-codegen fixSee Also
http://go/j/RUN_DEVSDK-3696
Configuration
skip-changefile: This PR is not a user-facing change, so there's no changefile.