Repository navigation
Reject blank webhook secrets 🪿✨ - #1940
Merged
Merged
Conversation
Committed-By-Agent: goose Orbit-Session-Id: a8a3ff0b-2818-4677-9877-6974eda81782
zacchua-stripe
requested review from
jar-stripe
and removed request for
a team
October 2, 2026 23:28
zacchua-stripe
marked this pull request as draft
October 2, 2026 23:29
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
jar-stripe
reviewed
Oct 5, 2026
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
zacchua-stripe
marked this pull request as ready for review
October 6, 2026 22:12
jar-stripe
approved these changes
Oct 19, 2026
zacchua-stripe
enabled auto-merge (squash)
October 19, 2026 19:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Reject webhook secrets made entirely of ASCII whitespace so invalid configuration fails with the existing missing-secret errors instead of reaching HMAC verification.
What?
StripeEventNotificationHandlernow treat space, tab, CR, LF, form feed, and vertical tab-only values as blank while preserving nonblank secrets.See Also
http://go/j/RUN_DEVSDK-3378
Configuration
skip-changefile: This PR is not a user-facing change, so there's no changefile.