Skip to content

chore(release): prepare v4 warning and getter patch releases - #1127

Closed
omermorad wants to merge 6 commits into
masterfrom
chore/release-v4-core-413-fixes-only
Closed

omermorad wants to merge 6 commits into
masterfrom
chore/release-v4-core-413-fixes-only

Conversation

@omermorad

@omermorad omermorad commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

Publish only the v4 patches: @suites/core.unit@4.1.3, @suites/doubles.jest@4.1.3, and @suites/doubles.vitest@4.1.3. Unit remains published at 4.1.2. The 4.2.0 candidate was tagged but never uploaded to npm; this PR restores package code and E2E fixtures to the published 4.1.2 state, then applies only the Core warning and Jest/Vitest getter fixes. Relative to the published source, the package changes are confined to those three packages.

Core now records the override actually selected by dependency resolution, so a qualified override selected through a bare token is no longer falsely reported as unused. The doubles adapters preserve accessors without evaluating getters during setup, and lazily create deep mocks for getter/setter objects. Tests cover selected and unused overrides, false final values, getter spies, descriptor preservation, nested mocks, and replacement identity.

The read-only release plans on this commit must show:

  • Publish: Core 4.1.3, Jest doubles 4.1.3, Vitest doubles 4.1.3.
  • Preserve: Unit 4.1.2 and the other six published packages. No overall Unit release tag is needed.
  • Existing signed 4.2.0 Git tags remain at their original commit and are not moved or reused.

The standard automated Lerna version step sees the aborted 4.2.0 tags and would include rollback changes as package changes. This PR therefore reviews explicit patch versions and changelogs; Tag Release and Publish Packages consume those reviewed manifests and verify each existing or new tag.

Validation: final-commit full build, lint, all package tests, and read-only tag/publication plans pass. All 24 release lifecycle tests passed; release scripts were unchanged by the adapter additions. Hosted CI, packed E2E (30 consumers), and Verdaccio release simulation all pass.

Merging this chore/release- PR invokes Tag Release and its release-environment approval. After the three new package tags are verified, run Publish Packages on master with the exact merge commit and no overall release tag. This PR itself does not tag or publish packages.

The deferred fluent APIs and their follow-up fixes remain on #1123; the remote E2E harness remains on #1125. Neither is part of this patch release.

@codecov

codecov Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.30894% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.78%. Comparing base (8732773) to head (fee5d3d).

Files with missing lines Patch % Lines
packages/core/src/services/dependency-resolver.ts 81.25% 3 Missing and 3 partials ⚠️
packages/doubles/vitest/src/mock.static.ts 96.87% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1127      +/-   ##
==========================================
- Coverage   93.02%   91.78%   -1.24%     
==========================================
  Files          27       28       +1     
  Lines         645      609      -36     
  Branches      117       98      -19     
==========================================
- Hits          600      559      -41     
- Misses         27       30       +3     
- Partials       18       20       +2     
Flag Coverage Δ
core.unit 93.61% <89.83%> (-3.24%) ⬇️
di.injectionjs 100.00% <ø> (?)
di.inversify 87.73% <ø> (ø)
di.nestjs 87.25% <ø> (ø)
doubles.jest 100.00% <100.00%> (ø)
doubles.vitest 97.82% <96.87%> (+0.76%) ⬆️
unit 84.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@omermorad omermorad changed the title chore(release): prepare Core 4.1.3 fix-only publication chore(release): prepare v4 warning and getter patch releases Nov 10, 2026
@omermorad
omermorad marked this pull request as draft November 11, 2026 06:33
@omermorad omermorad closed this Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant