Repository navigation
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1127 +/- ##
==========================================
- Coverage 93.02% 91.78% -1.24%
==========================================
Files 27 28 +1
Lines 645 609 -36
Branches 117 98 -19
==========================================
- Hits 600 559 -41
- Misses 27 30 +3
- Partials 18 20 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
omermorad
marked this pull request as draft
November 11, 2026 06:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publish only the v4 patches:
@suites/core.unit@4.1.3,@suites/doubles.jest@4.1.3, and@suites/doubles.vitest@4.1.3. Unit remains published at 4.1.2. The 4.2.0 candidate was tagged but never uploaded to npm; this PR restores package code and E2E fixtures to the published 4.1.2 state, then applies only the Core warning and Jest/Vitest getter fixes. Relative to the published source, the package changes are confined to those three packages.Core now records the override actually selected by dependency resolution, so a qualified override selected through a bare token is no longer falsely reported as unused. The doubles adapters preserve accessors without evaluating getters during setup, and lazily create deep mocks for getter/setter objects. Tests cover selected and unused overrides, false final values, getter spies, descriptor preservation, nested mocks, and replacement identity.
The read-only release plans on this commit must show:
The standard automated Lerna version step sees the aborted 4.2.0 tags and would include rollback changes as package changes. This PR therefore reviews explicit patch versions and changelogs; Tag Release and Publish Packages consume those reviewed manifests and verify each existing or new tag.
Validation: final-commit full build, lint, all package tests, and read-only tag/publication plans pass. All 24 release lifecycle tests passed; release scripts were unchanged by the adapter additions. Hosted CI, packed E2E (30 consumers), and Verdaccio release simulation all pass.
Merging this
chore/release-PR invokes Tag Release and its release-environment approval. After the three new package tags are verified, run Publish Packages on master with the exact merge commit and no overall release tag. This PR itself does not tag or publish packages.The deferred fluent APIs and their follow-up fixes remain on #1123; the remote E2E harness remains on #1125. Neither is part of this patch release.