Skip to content

fix(release): prepare 4.1.3 maintenance patches - #1128

Open
omermorad wants to merge 7 commits into
release/4.1from
chore/release-413-maintenance
Open

omermorad wants to merge 7 commits into
release/4.1from
chore/release-413-maintenance

Conversation

@omermorad

@omermorad omermorad commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

4.1 maintenance patch

Base: signed v4.1.2 source commit 2a69a590951a11a91056bf9e9e3a0c9d551d0b6e on the protected release/4.1 branch.

Publish only these reviewed package versions:

  • @suites/core.unit@4.1.3: count selected overrides in usage warnings.
  • @suites/doubles.jest@4.1.3: preserve getter mocks without eager access.
  • @suites/doubles.vitest@4.1.3: preserve getter mocks without eager access.

All other package manifests and source trees match v4.1.2; @suites/unit remains 4.1.2. The existing signed 4.2.0 tags are untouched. This branch avoids rolling back the unreleased 4.2 code on master.

Release workflow

Tag and Publish now accept only master or release/4.1. The reviewed commit and selected branch are checked before tagging, and Publish still requires the exact workflow SHA, verified tags, full E2E simulation, the release environment, and npm provenance. A CI job runs read-only tag and npm publication plans on this PR.

Before merging, verify that the PR's publication plan lists exactly the three 4.1.3 versions and that all required checks pass. The protected release/4.1 branch has been added as an exact allowed branch in the existing release environment; its required reviewer gate remains in place. Do not use Prepare Release for this maintenance patch because Lerna sees the existing 4.2 tags.

Validation

Local pnpm build, pnpm lint, pnpm test, and pnpm test:release passed. The read-only tag plan preserves the seven unchanged package tags and proposes the three 4.1.3 tags without an overall Unit tag. Hosted CI passed, including the read-only npm plan: exactly three 4.1.3 packages to publish and seven existing versions to preserve. CodeQL and the 30 consumer E2E jobs passed.

Previous release compatibility passed in an isolated verification PR using the harness from #1125. It froze the published 4.1.2 consumers at commit 2a69a590951a11a91056bf9e9e3a0c9d551d0b6e, ran them against their published packages, then ran the same tests against the candidate tarballs. All 30 consumer/runtime comparisons and the current subclass regression consumer passed. The harness was kept out of this fixes-only release PR.

After the maintenance release, forward-port these fixes to master separately. Do not merge the maintenance branch wholesale into master.

@codecov

codecov Bot commented Nov 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.75000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.78%. Comparing base (2a69a59) to head (55f9abd).

Files with missing lines Patch % Lines
packages/doubles/vitest/src/mock.static.ts 97.05% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release/4.1    #1128      +/-   ##
===============================================
+ Coverage        90.95%   91.78%   +0.83%     
===============================================
  Files               26       28       +2     
  Lines              553      609      +56     
  Branches            90       98       +8     
===============================================
+ Hits               503      559      +56     
  Misses              30       30              
  Partials            20       20              
Flag Coverage Δ
core.unit 93.61% <100.00%> (+0.13%) ⬆️
di.injectionjs 100.00% <ø> (?)
di.inversify 87.73% <ø> (ø)
di.nestjs 87.25% <ø> (ø)
doubles.jest 100.00% <100.00%> (ø)
doubles.vitest 97.82% <97.05%> (+0.95%) ⬆️
unit 84.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@omermorad
omermorad marked this pull request as ready for review November 11, 2026 07:13

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant