tigris: fix shadow-bucket and delete examples - #2469
Open
tripledoublev wants to merge 1 commit into
Open
Conversation
Delete guidance advertised a nonexistent --force flag and had the empty/non-empty deletion rule backwards. fly storage destroy has no --force; it prompts for confirmation unless --yes is passed, and deletion is unconditional regardless of bucket contents. Shadow bucket create/update examples were missing the required --shadow-name flag. flyctl rejects a partial shadow configuration (all five of name, access key, secret key, endpoint, region are required) before any provider call, so the old examples would fail as written.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two customer-facing defects on the Tigris storage page:
--forceflag and had the empty/non-empty deletion rule backwards.fly storage destroyhas no--force; it prompts for confirmation unless--yesis passed, and deletion is unconditional regardless of bucket contents.--shadow-nameflag. flyctl rejects a partial shadow configuration client-side (all five of name, access key, secret key, endpoint, region are required) before any provider call — the old examples would fail as written.Verification
Independently reviewed by two separate models across multiple passes, all claims re-verified directly against current flyctl source (
internal/command/extensions/tigris/{destroy,create,update,tigris}.go), not against the docs' own prior wording.Scope note
A related edit (documenting shadow-bucket update semantics for
--shadow-write-through) is intentionally left out of this PR — see #2470, opened as a draft, blocked on a separate flyctl fix that hasn't merged yet. Shipping that wording now would describe behavior that isn't live yet.