Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A host cannot currently select a disk packet cache on tvOS or a memory packet cache on other platforms without replacing the platform policy. Add
LoadOptions.softwarePacketCacheStorage(automatic,disk,memory) and carry it through the existing load/rebuild path.automaticretains the policy introduced in #776: purgeable memory on tvOS and disk elsewhere. Explicit disk retains volume/multi-session safeguards and direct playback on cache-initialization failure. Explicit memory keeps the existing forward/history bounds and reclaimable played history. Local direct-file reads, live DVR and native HLS remain unchanged. This is an opt-in host control, not a proposal to revert the measured tvOS default.The internal factory is the production construction path; tests exercise real stores, disk failure/claim release, default selection and reload-option accounting. Public contract and changelog are included. Byte-budget controls are a separate contribution.
Validation on an Apple Silicon Mac (Mac17,3), macOS 26.7.1 / Swift 6.4:
swift build --build-testspassed; executables signed and verified with a valid Apple Development identity.git diff --checkpassed.The default matrix's tvOS leg is conditional test coverage for a tvOS runner; it was not executed by the macOS host run. Platform builds and all-traits tests remain subject to upstream CI. No new device/media performance acceptance is claimed; #776's flash-contention evidence is why the automatic default stays unchanged.