Repository navigation
Conversation
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fully prewarmed file still starts a speculative suffix request on open: adoption installs the whole head, but the
warm.tail == nilcheck treats the missing separate tail span as missing bytes. A 40 KiB source is fetched again byRange: bytes=-65536even though its entire content is resident. The existing immediate request-count assertion can pass before that asynchronous request reaches the origin; this caused the all-traits failure observed on #823.Skip tail prefetch only when the adopted head covers its declared content length. Partial warms, cold opens, header identity checks, redirect handling and memory-pressure eviction retain their existing paths. No public API or dependency change.
Strengthen the full-warm test with a bounded observation of absence, covering files smaller and larger than the suffix budget. Add a positive witness that partial warming still requests the missing suffix. The existing redirect/header-mismatch coverage runs alongside them.
Upstream context: #551, #554 and #584 already provide prewarm and resolved-target adoption; this fills the complete-head boundary they leave open. The affected production and test files are identical on main
151322d1b843b4414a0fcffa9ed44e8b3a9d087eand #823. This independent fix does not alter #823's audio coverage scope.Validation on Apple Silicon Mac17,3, macOS 26.7.1 / Swift 6.4:
bytes=-65536.SoftwarePacketMemoryFIFOTests.evictPurgedHistorytest (lines 99/102/103). Its consumed-history residency assumption is exactly the issue addressed by open test(cache): respect kernel purges in history eviction checks #819. This PR changes neither that test nor the memory FIFO; the isolated 11-test memory FIFO suite subsequently passed without changes. The full-run failure is retained and is not reported as a full-suite pass.git diff --checkpass. Host executables are signed and verified with a valid Apple Development identity; linker ad-hoc signing is disabled.Other platforms and all-traits coverage are left to CI. No new device playback acceptance is claimed.