Repository navigation
Fix crash in debug when request body stream finishes after a >= 300 response head - #934
Merged
Merged
Conversation
gjcairo
approved these changes
Oct 7, 2026
o-nnerb
added a commit
to request-dl/async-http-client
that referenced
this pull request
Oct 7, 2026
* Fix crash in debug when request body stream finishes after a >= 300 response head (swift-server#934) ### Motivation If a server responds with a status >= 300 while we are still uploading the request body, we ask the producer to pause the request body stream. The producer may still finish the stream, because it raced with the pause request. In this case we hit `assert(head.status.code < 300)` in `HTTPRequestStateMachine.requestStreamFinished`, which crashes debug builds. ### Changes - Remove the wrong assertion. Finishing the request body stream after a >= 300 response head is a valid state transition: we send the request `.end` and move into `.endSent`. - Add a reproducer in `HTTPRequestStateMachineTests` that streams a body part, receives a 413 Payload Too Large head and then finishes the request body stream. ### Result A request body stream that finishes after the server responded with a `status >= 300` no longer crashes in debug. Since the request `.end` is on the wire, the connection can be reused after the response ends. --------- Co-authored-by: Eric Rosenberg <eric_rosenberg@apple.com> * Lift minimum Swift version to 6.2 (swift-server#935) Co-authored-by: Si Beaumont <simonjbeaumont@gmail.com> --------- Co-authored-by: Fabian Fett <fabianfett@apple.com> Co-authored-by: Eric Rosenberg <eric_rosenberg@apple.com> Co-authored-by: Si Beaumont <simonjbeaumont@gmail.com> Co-authored-by: brennobemoura <37243584+brennobemoura@users.noreply.github.com> Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
If a server responds with a status >= 300 while we are still uploading the request body, we ask the producer to pause the request body stream. The producer may still finish the stream, because it raced with the pause request. In this case we hit
assert(head.status.code < 300)inHTTPRequestStateMachine.requestStreamFinished, which crashes debug builds.Changes
.endand move into.endSent.HTTPRequestStateMachineTeststhat streams a body part, receives a 413 Payload Too Large head and then finishes the request body stream.Result
A request body stream that finishes after the server responded with a
status >= 300no longer crashes in debug. Since the request.endis on the wire, the connection can be reused after the response ends.