Repository navigation
Ensure request body iteration is cancelled when request is cancelled - #936
Closed
hamzahrmalik wants to merge 1 commit into
Closed
hamzahrmalik wants to merge 1 commit into
hamzahrmalik wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently, if users pass an async sequence as the request body, AHC will iterate that sequence in an unstructured task. If the request is cancelled or times out, execute(...) returns, but the body is still being iterated by the unstructured task. This breaks structured concurrency. Specifically, this can result in concurrent access if the caller then retries the request or otherwise uses the async sequence again.
Change
Store the unstructured task, and cancel and await is when the request is failed.
Note: This means execute might now take longer than the specified timeout, if the sequence does not cancel quickly