Repository navigation
Drop @unchecked from compiler-checkable Sendable conformances - #947
Merged
Merged
Conversation
SingleIteratorPrecondition only stores the base sequence and a ManagedAtomic, and HTTPHeadersInjector has no stored properties, so the compiler can verify both conformances without @unchecked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Two
Sendableconformances are marked@uncheckedeven though the compiler can verify them:SingleIteratorPreconditionstores onlylet base: Baseandlet didCreateIterator: ManagedAtomic<Bool>. With the existingwhere Base: Sendableconstraint, every stored property isSendable.HTTPHeadersInjectorhas no stored properties.Keeping
@uncheckedhere means the compiler would not catch a future change that breaks sendability.Modifications
@unchecked SendablewithSendableon both types.Result
No behavior change; the conformances are now checked by the compiler.
Verified locally on macOS (Swift 6.4.2):
swift build --build-tests -Xswiftc -strict-concurrency=completeproduces no new diagnostics.swift testpasses excepttestConnectTimeout(x2), which also fails on unmodifiedmainin my environment (connection reset instead of timeout) and is unrelated to this change.