Repository navigation
BridgeJS: Normalize pointer in swift_js_push_typed_array - #828
Merged
kateinoigakukun merged 1 commit intoNov 7, 2026
Merged
kateinoigakukun merged 1 commit into
kateinoigakukun merged 1 commit into
Conversation
kateinoigakukun
approved these changes
Nov 7, 2026
kateinoigakukun
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks! This was the last pointer offset in the generated glue that wasn't normalized.
kateinoigakukun
enabled auto-merge (squash)
November 7, 2026 07:27
Member
Author
|
Yeah, missed tytanowe initially 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Follow-up to #768, which normalized wasm pointer offsets with
>>> 0in the generated BridgeJS glue. It missed one site:swift_js_push_typed_array, added by #745, which copies a Swift numeric array out of linear memory into a JS array.Once memory grows past 2 GiB,
ptrarrives as a negativei32.ArrayBuffer.slicetreats a negative index as an offset from the end of the buffer, so the copy reads the wrong bytes and JS silently gets wrong values. This PR normalizesptrbefore the slice.Before:
After: