Repository navigation
Scope the neural audit around the zip 8.6 advisories Candle cannot avoid - #49
Merged
Merged
Conversation
candle-core 0.11.0, the newest release, requires zip ^8.6.0, and the fix for RUSTSEC-2026-0367 and RUSTSEC-2026-0369 is in zip 9. Candle only reads archive entries and never extracts to disk, and the worker loads only the pinned safetensors model, so the audit ignores the two advisories and SECURITY.md records why. Closes #44 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
enaboapps
marked this pull request as ready for review
October 17, 2026 11:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44
neural-auditfails onmainbecausezip8.6.0 now carries RUSTSEC-2026-0367, RUSTSEC-2026-0368 and RUSTSEC-2026-0369. All three are patched only inzip9, andcandle-core0.11.0, the newest release, requires^8.6.0, so there is no semver-compatible lock file update.cargo update -p zipchanges nothing.What changes
.github/workflows/neural.ymlignores the three advisories beside the existingpasteexception.neural/SECURITY.mddocuments all four exceptions: the advisories concernextract()writing attacker-controlled archives to disk with kept SUID/SGID bits, permissions through symlinks and symlink targets outside the destination; Candle only reads.npzand pickle entries throughZipArchive::newand writes.npzthroughZipWriter, never callingextract(), and the worker loads only the hash-pinned GGUF model. The exceptions are to be removed when Candle moves tozip9.The lock file, code and model outputs are unchanged, so the pinned-model tests and third-party notices need no regeneration.
Validation
neural-auditjob on this PR.🤖 Generated with Claude Code