Repository navigation
fix: check .nix files; stop testing configuration - #155
Merged
Merged
Conversation
systemfsoftware-bot
changed the title
systemfsoftware-bot
added a commit
that referenced
this pull request
Nov 2, 2026
#155 mapped `.nix` to the Nix grammar, but `TSLP_LANGUAGES` did not list `nix`, so the grammar was never compiled and `.nix` files were still skipped. Built locally, a `.nix` write with a TODO and commented-out code is now flagged. Co-authored-by: systemfsoftware-bot <318394648+systemfsoftware-bot@users.noreply.github.com>
1 task
mergify Bot
pushed a commit
that referenced
this pull request
Nov 11, 2026
## Summary #155 dropped three verifications from CI; this restores them. The merge queue can see the check it requires again (`actionlint + version surfaces`), CI again fails when the Nix-built binary reports a version other than `package.json`'s, and the platform workflow again fails on an unknown `mode` instead of passing having built nothing. `.mergify.yml` is unchanged. ## Which case it was The version-surfaces verification was dropped, not just renamed. Commit 5958ac8 (#155, "fix: check .nix files; stop testing configuration") changed the `checks` job in one edit: - `name: actionlint + version surfaces` became `name: actionlint`. - The step `Version surfaces agree (release.jsonc, checked by the locked release toolchain)` (`version-management sync check`) was deleted. `.mergify.yml`, added earlier in 9e44128 (#141), still requires `check-success = actionlint + version surfaces`, so no PR could satisfy it. `git log -S'actionlint + version surfaces'` shows 5958ac8 as the only commit that removed the string from the workflow, and nothing on `master` runs `version-management sync check` any more. The step first came from 44e1c87 (#138), which retired the repository-local version gate in favour of this toolchain check. The first commit restores the job name and the step as they were before #155. On `master` the check passes (`sync-versions: ok — 0.3.6 across the manifest and every surface`), so restoring it does not turn existing PRs red. ## Other checks #155 dropped - **Built binary version** (`nix` job, "Smoke the built binary version"): compares `comment-checker --version` from the Nix build with `claude-code-comment-checker <package.json version>`. It was the binary-identity check 44e1c87 kept when it retired `run-binary-smoke.ts`. Restored with the same command; the rationale for smoking the unwrapped binary (the bwrap wrapper needs `--unshare-net`, which Actions containers do not permit) moved from a YAML comment into the step name, because this repository's comment checker flags it as redundant. - **Unknown `mode`** (`platform.yml`, "Reject unknown mode"): without it a typo in a caller's `mode` skips every `inputs.mode == ...` step and the job goes green having built and staged nothing. #155's description lists this among the deletions as checking only configuration. It guards a caller-supplied input, so it is restored as it was. ## Left deleted The `hook_commands.rs` changes in #155 stay as they are: - `repo_settings_hook_runs_the_readme_hook_command` asserted that two config files hold the same string. It restates the configuration and exercises no behavior. - `exactly_one` (now `first`) counted the hook entries in config files. Same reason. - `real_direnv_exits_1_without_running_the_command_when_envrc_is_blocked_or_command_is_missing` runs only the `direnv` binary and never the hook script or the checker, so it tests a third party's behavior and fails or passes with no change to this repository. Its `direnv` install step in `rust-gate.yml` is tooling for that test alone, so it stays deleted too. ## Unapplied review findings - [ ] P3 — `.mergify.yml:14` — `merge_conditions` do not include `actionlint + version surfaces`. Intended: the commit and surface checks are judged on the PR, the gate on the queue draft, as in `systemfsoftware/systemfsoftware`. Residual risk: nothing checks that the check names in `.mergify.yml` match the workflow's job names, so another rename would strand the queue the same way. The Mergify rule that stops approvals from queueing PRs on `master` is fixed at its source in the organization's `.github` repository, in its own PR. ## Testing - `nix shell --inputs-from . pnpm-release-management#release-tools -c version-management sync check` exits 0. - The restored smoke command, run locally: Nix-built binary reports `claude-code-comment-checker 0.3.6`, equal to the expected value. - The restored mode case statement, run locally under bash: `rehearsal` exits 0, `bogus` exits 1 with the message. - `actionlint` (locked nixpkgs) exits 0. - `cargo fmt --check`, `cargo clippy --all-targets -- -D warnings`, `cargo test --all-targets` pass locally. Mutation was not run: no classifier change. - Pending on CI: the `actionlint + version surfaces`, `nix flake check` and `packaging / rehearsal` jobs on this PR's head. - Code review: focused path with one local adversarial reviewer (run `20261111-015121-2650e7a1`, status complete, depth focused) on the first commit. The later commits restore deleted lines verbatim and were not separately reviewed. --- [](https://github.com/EveryInc/compound-engineering-plugin)
9 of 10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes.
.nixfile because.nixhad no entry in the extension map. It now maps to the Nix grammar the language pack already ships..claude/settings.jsonmatching the README, the hook config holding exactly one hook, version numbers agreeing across files, the binary's--versionmatchingpackage.json, the workflow rejecting an unknown mode input, and the test of direnv's own behavior along with its install step. What remains runs the checker and the hook script.This also fixes master's red CI: #148 nested the plugin hook under
hooksinhooks/hooks.json, and the hook tests read the old top-level key.