Repository navigation
refactor(schema)!: conform to the effect-tsgo 0.54 lint rules - #2
Merged
Merged
Conversation
Adds { readonly brand: unique symbol } as the second type argument of
Schema.Class, TaggedClass and TaggedError, types InvokeRead's read part as the
class's fields without the brand, and rewrites flat-map-to-tap and
sleep-zero-to-yield-now. None of it needs tsgo 0.54 to compile.
Ported from the packages/discern slice of systemfsoftware/systemfsoftware#874.
Claude-Session: https://claude.ai/code/session_017rX35xUAHEjVVaDKVVzubW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the packages/discern slice of systemfsoftware/systemfsoftware#874 on top of the merged discern#1. Schema.Class, TaggedClass and TaggedError gain a
{ readonly brand: unique symbol }second type argument,InvokeReadtypes its read part as the class's fields without the brand, and flat-map-to-tap and sleep-zero-to-yield-now rewrites apply. No changesets in this repo.Checked locally: typecheck, lint, vitest (298 passed), tstyche, build with api-extractor, dprint.
https://claude.ai/code/session_017rX35xUAHEjVVaDKVVzubW