Repository navigation
fix(deps): require effect 4.1.2 - #5
Merged
Merged
Conversation
There was a problem hiding this comment.
Conductor verdict: success at 5d89adb. Full review complete with 0 findings; CI green; patch changeset 'Requires Effect ^4.1.2.'; peers ^4.1.2; tsgo override kept pending SYS-990; lint 345 to 350.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Effect Readiness now requires Effect ^4.1.2; its direct Effect dependencies resolve to 4.1.2 and @effect/tsgo resolves to 0.64.1.
The existing @effect/tsgo override remains at 0.64.1 because the org oxlint preset still requires a 0.x caret range (SYS-990). @systemfsoftware/stryker-js@17.0.2 still brings @effect/platform-node@4.1.0 transitively; upstream dependency upgrades belong in their source repositories (SYS-1075), not overrides here.
Related to SYS-1063
Verification:
nix develop --command pnpm check:localpassed before and after the upgrade. Oxlint reported 345 rules before and 350 after, with zero warnings and errors in both runs. A built-package smoke run decoded a log readiness condition successfully.