Repository navigation
Let rk cross-modules take the reference boot from rk test - #259
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Fedora 7.4 run against gcc-14 (43997097793) ran out of time in rk cross-modules. Each kunit boot of that config takes about 95 minutes on the runner, and cross-modules boots three of them two at a time, so the third boot started at the 95 minute mark and was cut off 25 minutes later. Nothing in the kernels was wrong.
The first of the three boots is the reference kernel with its own modules, which is the boot rk test has just run as
reference-kunit-1. This adds--tested DIRto rk cross-modules. When the rk test run directory has that boot's outcome and console for a run, cross-modules reads it from there and only boots the two crossed cells, side by side. A run without it boots all three as before.The nightly passes
--tested "$RUNNER_TEMP/test", so the step needs one round of boots and not two, and the Fedora config fits in the job.Checked on server3 with cargo fmt, clippy and the cross tests, including a new one for reading the tested boot.