Repository navigation
Keep make from compiling the swapped objects again in rk mix and rk mixed - #263
Merged
Merged
Conversation
25 of 37 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rk mixandrk mixedhave not been linking rucc objects at all. The copy of the reference keeps objtool's.cmdfiles, and those name every target by its absolute path, which is still the reference's path. make takes that as a changed command and builds objtool again. Every kernel object depends on objtool, so make then compiled every object again with gcc, over the rucc objects that had just been written in. On a 7.4-rc2 tinyconfig on server3 the mix make log had 766 CC lines, and the mix'smm/memory.owas gcc's (63768 bytes, rucc's is 71024).So every mix bench on #244 so far measured a gcc kernel against a gcc kernel, which is why they all came out near 1.00. Any
rk mixedtrial was also run on gcc objects only.The fix:
copy_treenow moves the reference's path to the copy's in the.cmdand.dfiles undertools/. The kernel's own.cmdfiles are left alone, since they have to keep the reference's shim path.misc.o,piggy.oandheader.o), and make rightly builds those again. They are named on stderr and dropped from the list. If make built every swapped object again, the command fails rather than bench or boot a gcc kernel.On the same tinyconfig the make log now has 2 CC lines, 810 rucc objects stay in,
mm/memory.ois rucc's, and the mix vmlinux differs from gcc's. Clippy and the mixed tests pass, and there is a new test for the copy and the check.Part of #244.