Repository navigation
fix(mapping): replace double brace initialization in timezone generator - #152
Merged
nickkkccc merged 1 commit intoNov 5, 2026
Conversation
nickkkccc
reviewed
Nov 4, 2026
Contributor
Author
There was a problem hiding this comment.
Fixed, added trailing newline.
Reactivity512
force-pushed
the
fix(jackson-mapping)/timezone-generator
branch
from
November 5, 2026 17:33
2abd824 to
a1fea65
Compare
nickkkccc
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What has been done? Why? What problem is being solved?
This PR updates the gen-timezones.sh script to generate TarantoolTimezones.java without using the "Double Brace Initialization" anti-pattern.
Why is this change needed?
Code Quality: Double brace initialization creates unnecessary anonymous inner classes and holds hidden references to the enclosing instance, posing a potential memory leak risk.
Static Analysis: This pattern is flagged by Google Error Prone (DoubleBraceInitialization), which we are currently integrating into the project to enforce higher code quality standards.
I haven't forgotten about:
Closes #151