Repository navigation
style(mapping): format generated timezones and add license header - #155
Merged
Merged
Conversation
e954851 regenerated TarantoolTimezones.java without the license header and with tab indentation, so spotless:check fails on master and on every branch based on it. Format the file with google-java-format 1.28.0 and make gen-timezones.sh emit the same layout, so a regenerated file passes as is.
nickkkccc
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spotless-checkfails on master since e954851 and on every branch rebased onto it (#139, #154): e954851 regeneratedTarantoolTimezones.javawithout the license header and with tab indentation. The job hascontinue-on-error, so the workflow stays green and the failure is easy to miss.style(mapping): format generated timezones and add license header— the file is formatted with google-java-format 1.28.0 (the version frompom.xml) and gets the license header; the maps are unchanged (the file is identical to e954851 ignoring whitespace and the header).gen-timezones.shnow emits the header and the same layout, so a regenerated file passesspotless:checkas is: the script run ontimezones.hfrom the same Tarantool commit produces this file byte for byte.spotless-checkпадает на master начиная с e954851 и на всех ветках, перебазированных на него (#139, #154): e954851 перегенерировалTarantoolTimezones.javaбез шапки лицензии и с отступами табами. У заданияcontinue-on-error, поэтому workflow остаётся зелёным и падение легко пропустить.style(mapping): format generated timezones and add license header— файл отформатирован google-java-format 1.28.0 (версия изpom.xml) и получил шапку лицензии; таблицы не изменились (без учёта пробелов и шапки файл совпадает с e954851).gen-timezones.shтеперь выдаёт шапку и ту же раскладку, так что перегенерированный файл проходитspotless:checkбез правок: скрипт наtimezones.hиз того же коммита Tarantool выдаёт этот файл байт в байт.I haven't forgotten about: