Skip to content

🐛 Keep the session-name assertion off the random profile root (#714) #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taras merged 1 commit into from
Sep 2, 2026
Merged

🐛 Keep the session-name assertion off the random profile root (#714) #716

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/cli/tests/plan.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import { ensure, scoped, spawn, until } from "effection";
import type { Operation } from "effection";
import { ensureDir, readTextFile, rm, writeTextFile } from "@effectionx/fs";
import { readdir } from "node:fs/promises";
import { join, sep } from "node:path";
import { join, relative, sep } from "node:path";
import { API, stat } from "@executablemd/runtime";
import { Elicitation } from "@executablemd/core";
import type { ElicitationRequest } from "@executablemd/core";
Expand Down Expand Up @@ -419,9 +419,11 @@ describe(
expect(namedDirectories[0]).toBe(namedDirectories[1]);
expect(survived).toEqual([true, true]);
// The name never reaches the path, and the digest is what the host
// derived from it.
// derived from it. Only the leaf is the host's to keep the name out of:
// the root above it carries a random hex UUID, which spells "ada" one
// run in a hundred or so.
expect(namedDirectories[0]).toBe(authorshipDirectoryFor(authorshipRoot, "ada"));
expect(namedDirectories[0]).not.toContain("ada");
expect(relative(authorshipRoot, namedDirectories[0])).not.toContain("ada");

// The second invocation continued the record the first established
// rather than placing a second one: the store holds one, and only the
Expand Down
Loading