fix: don't assume treeherder.group-names exists in graph config - #1024
Open
ahal wants to merge 1 commit into
Open
fix: don't assume treeherder.group-names exists in graph config#1024ahal wants to merge 1 commit into
ahal wants to merge 1 commit into
Conversation
Some projects don't use Treeherder at all, we shouldn't assume this config exists. Also move it outside the for loop so we only check once.
Eijebong
reviewed
Aug 14, 2026
Eijebong
approved these changes
Aug 19, 2026
Eijebong
left a comment
Eijebong
left a comment
Contributor
There was a problem hiding this comment.
I guess at least the error will be better than a key error if it adds a config containing a th group 🤷
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some projects don't use Treeherder at all, we shouldn't assume this config exists.
Also move it outside the for loop so we only check once.