Repository navigation
Conversation
The HTML standard closes an empty comment at <!--> (comment start state) and at <!---> (comment start dash state), and everything after it is text. The lexer only looked for --> and --!> after moving past <!--, so <!-->x--> and <!--->x--> were lexed as a single comment and the text in between was lost, which through minify drops content that browsers render.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HTML lexer does not end a comment at an abrupt close. Per the HTML standard,
<!-->(comment start state,>: "abrupt-closing-of-empty-comment") and<!--->(comment start dash state,>) both close an empty comment, and whatever follows is text. The lexer only looks for-->and--!>after moving past<!--, so it keeps reading:Through
tdewolff/minifythis drops content:<em><!-->x--></em>minifies to<em></em>, where browsers renderx-->.The fix checks for
>or->right after<!--and emits an empty comment there.<!---->,<!-- -->,<!-- --!>and unterminated comments behave as before. Added five cases toTestTokens(<!-->,<!--->,<!---->, and the two followed by text);go test ./htmlpasses, and the new cases fail on master (<!-->text-->is one token there).Found by comparing the lexer with
golang.org/x/net/html's tokenizer on generated documents while checking minify's HTML output.