Repository navigation
Conversation
An ident sequence followed by ( is a function token, and that includes dashed idents: --fn(1px) is the <dashed-function> syntax of CSS custom functions (css-values-5). The lexer returned every ident starting with -- as a CustomPropertyNameToken without looking at the next byte, so --fn( came out as a custom property name followed by a parenthesis, where css-tree and the specification give a single function token. Only a ( directly after the name changes; --x: and --fn ( are unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An ident sequence directly followed by
(is a function token, and that includes dashed idents:--fn(1px)is the<dashed-function>syntax of CSS custom functions (css-values-5 / css-mixins-1, shipping in Chrome). The CSS lexer returns every ident that starts with--as aCustomPropertyNameTokenwithout looking at the next byte, so--fn(comes out as a custom property name followed by a parenthesis:This checks for
(after the custom property name and returns aFunctionTokenin that case.--x:and--fn ((with whitespace before the parenthesis) are unchanged. Three cases added toTestTokens;go test ./...passes, and minify'scsstests pass against this branch (its output fora{width:--fn(1px)}is unchanged, since unknown functions are passed through).Found by comparing the lexer with css-tree's tokenizer on generated input. The other differences in that comparison are intentional in this lexer (a quoted argument stays inside the URL token,
\url(is treated as a URL) or on css-tree's side (\followed by NUL is a valid escape here, which matches the spec).