Repository navigation
isp2200, virtio: what mainline linux needs on the octane - #789
Merged
techomancer merged 5 commits intoNov 20, 2026
Merged
techomancer merged 5 commits into
techomancer merged 5 commits into
Conversation
Linux's qla2xxx logs in to each port on the loop with Login Loop Port (0x0074) and, from its discovery state machine, with mailbox commands carried in a request-ring entry (type 0x39: login, logout and the port database for ADISC). The model refused both, so the loop came up and no disk ever appeared. Answer 0x0074 for a present port, and serve those four commands in a ring entry, answered in an entry of the same type in the response ring; anything else sent that way is an invalid command. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Without VIRTIO_F_ACCESS_PLATFORM Linux bypasses the DMA API and writes physical addresses into the queue registers. Behind the Octane's Bridge a physical address below 1 GB is PCI-local space, so the device never read its rings and virtio_console spun for ever on its first control message. The PCI transport now offers the bit (a driver that does not accept it is still taken) and Linux hands over the Bridge's direct-window addresses. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
steigr
force-pushed
the
linux/isp2200-logins-and-virtio-access-platform
branch
from
November 19, 2026 21:31
80e99b2 to
e31d490
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two device fixes that let Linux 7.3 (Gentoo mips3 n64,
ip30_defconfigplus a few drivers) use the Octane's Fibre Channel and virtio devices.ISP2200 port logins. Linux's qla2xxx logs in to each loop port with Login Loop Port (0x0074). From its discovery state machine it also sends mailbox commands inside a request-ring entry (type 0x39: login, logout and port database). The model refused both, so the loop came up and no disk appeared. It now answers 0x0074 for a present port and serves those commands in a ring entry, answered in the response ring; anything else sent that way is an invalid command.
virtio ACCESS_PLATFORM. Without
VIRTIO_F_ACCESS_PLATFORM, Linux bypasses the DMA API and writes physical addresses into the queue registers. Behind the Bridge, a physical address below 1 GB is PCI-local, so the device never saw its rings andvirtio_consolespun on its first control message. The PCI transport now offers the bit (a driver that refuses it is still accepted) and Linux hands over direct-window addresses. This applies on the Tezro too.Also two clanker notes:
The Linux serial console also needs virtio-serial off Bridge slot 4. That change is in a separate PR, #788.
Tests (new):
port_login(loop tests),offers_access_platform.Guest check: Linux 7.3.4 on two CPUs on the Octane with the PCI cage, ISP2200 (two loop disks), NVMe, virtio-serial and virtio-9p. 18 passing runs, each with disk readback (system, FC, NVMe) by SHA-256, a 20k flood ping and an OpenSSL build.
Tested on macOS arm64 at the tip:
cargo test --workspace --no-fail-fast --release --features lightning,gpujit,jitv2andcargo build --release --binswith the same features. No failures beyond those upstream main shows on the same host (the five port-forward tests,ip35::tests::the_jitv2_compile_setting_reaches_every_product_and_drop_joins_the_pool,iris-guiswitching_from_a_populated_machine_leaves_a_valid_config).kona::back::tiles::tests::a_tiled_run_is_bit_exact_with_the_inline_onewas skipped (hangs under load on main).🤖 Generated with Claude Code