Repository navigation
jitv2: stop the idle compile worker polling every 200us - #800
Open
jamesbraid wants to merge 1 commit into
Open
jamesbraid wants to merge 1 commit into
jamesbraid wants to merge 1 commit into
Conversation
handle_request_deferred counts a compile whose range is not sealed yet in `pending`. When a later compile's seal attempt released that range, publish_all published it but `pending` stayed up, and the idle sweeps only subtract what they seal themselves. With nothing left in the seal queue `pending` never reached 0, so the worker kept the 200us publish backstop instead of the 20ms idle one. Subtract the entries a finalize releases other than the compile's own. At the Indy PROM menu the worker sat at pending=63 with an empty seal queue. Voluntary context switches of the compile thread over 10 s, on a loaded host, built-in PROM, headless: Indy 3770/s -> 49/s, O2 3763/s -> 49/s. The thread made 2 clock_gettime calls per wakeup. Fixes: 6d70615 ("multi threaded jit compiler")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handle_request_deferred counts a compile whose range is not sealed yet
in
pending. When a later compile's seal attempt released that range,publish_all published it but
pendingstayed up, and the idle sweepsonly subtract what they seal themselves. With nothing left in the seal
queue
pendingnever reached 0, so the worker kept the 200us publishbackstop instead of the 20ms idle one.
Subtract the entries a finalize releases other than the compile's own.
At the Indy PROM menu the worker sat at pending=63 with an empty seal
queue. Voluntary context switches of the compile thread over 10 s, on a
loaded host, built-in PROM, headless: Indy 3770/s -> 49/s, O2 3763/s ->
49/s. The thread made 2 clock_gettime calls per wakeup.
Fixes: 6d70615 ("multi threaded jit compiler")