Repository navigation
test: Add common-document regressions and fix layout defects - #462
Merged
Merged
Conversation
philprime
marked this pull request as ready for review
October 11, 2026 14:22
philprime
enabled auto-merge (squash)
October 11, 2026 14:22
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Generated by 🚫 Danger Swift against fde1a28 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build a regression corpus of original, synthetic office documents inspired by common report, invoice, résumé, newsletter, letter, and agenda layouts. Exercise A4, US Letter, landscape, and debug mode with explicit content counts/order, headers/footers, column bounds, section separation, visible ink, TOC, links, and multi-document packets.
Retain failing regressions for group padding leaking after a page move, double-counted top padding, and wrapped link hitboxes using reversed line origins and missing horizontal offsets. Keep group top padding active across continuation pages and wrapped columns so backgrounds cannot cover page headers. Fix only those existing behaviors. Also cover image-delegate replacement before drawing, corrupt/truncated external-file recovery with a fresh generator, and locked-PDF error handling. No production features or third-party template assets are added.
Builds on #461, which is now merged. This PR targets main.
Verification
Focused regressions failed before the fixes and passed afterward. The latest full macOS run passed 243 unit-test declarations and 21 integration-test declarations with no recorded issues. The full iOS 26.4.1 simulator run passed 236 unit-test declarations and 20 integration-test declarations. Parameterized coverage includes 36 office-document combinations, 12 mixed-font/alignment/debug link combinations, six group continuation layout cases, and four generated-PDF continuation cases. Lint and diff checks passed, and the testing flag is restored.
Earlier macOS runs exposed an intermittent existing font-reset assertion: the requested system-font expectation unexpectedly reported Helvetica 12, then the runner retried successfully. This remains unresolved and is not suppressed. Existing Sendable, redundant-macro, Xcode metadata, and PDF-context nesting diagnostics remain. Other platforms were not tested locally and are covered by CI. The default local iOS 26.2 simulator is absent, so the installed 26.4.1 simulator was used.