Repository navigation
build: Declare Swift package test targets unconditionally - #465
Merged
Merged
Conversation
philprime
marked this pull request as ready for review
October 11, 2026 15:53
philprime
enabled auto-merge (squash)
October 11, 2026 15:54
Generated by 🚫 Danger Swift against cc73d37 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Declare both Swift package test targets directly in the package manifest now that Quick and Nimble are gone. Tests are available without toggling a flag or rewriting Package.swift, with their existing resources unchanged.
Remove the Makefile enable/disable targets and the testing-disabled pre-commit hook, including its obsolete Package.resolved guard. Update the repository testing instructions to match.
Verification
The manifest assertion for both test targets failed before the change and passed afterward. Focused macOS tests passed, followed by
make test-macoswith 243 unit tests and 21 integration tests.make lint,git diff --check, and commit hooks passed.Only macOS was tested. Existing watchOS deployment-target deprecation, Xcode destination/launch diagnostics, and the invalid-PDF CoreGraphics diagnostic remain.
Scope
Branched independently from freshly fetched origin/main. This PR does not include or depend on the CocoaPods cleanup.