Repository navigation
fix(repository-environment): scope metadata name by repository - #46
Merged
Merged
Conversation
Terraform Integration
✅ All 1 passed. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
local.metadata.nameidentifies the module instance. It is used for themodule.terraform.io/instancetag and the upcoming module usage telemetry. Forrepository-environment, the previous value is not unique: an environment name is only unique within its repository.This PR makes it unique, following
record-setinterraform-aws-domain("${var.zone}/${var.name}/${var.type}").Changes
local.metadata.name:var.name→"${var.repository}/${var.name}"Impact on existing callers
local.metadata.nameis not referenced by any resource in this module yet, so there is no plan diff.