Skip to content

fix(org-ruleset): correct RepositoryRole bypass actor IDs in description - #56

Merged
posquit0 merged 1 commit into
mainfrom
fix/org-ruleset-repository-role-ids
Nov 20, 2026
Merged

posquit0 merged 1 commit into
mainfrom
fix/org-ruleset-repository-role-ids

Conversation

@posquit0

@posquit0 posquit0 commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

Background

  • The bypass_list.*.actor.id description in modules/org-ruleset/variables.tf:36 listed the RepositoryRole IDs as 1 (maintain), 2 (write), 3 (admin), 4 (read), 5 (triage). The provider documentation gives a different mapping: maintain -> 2, write -> 4, admin -> 5 (and OrganizationAdmin -> 1).
  • Impact: a caller who follows the description grants bypass to the wrong role, e.g. 5 meant as "triage" actually grants bypass to admin, and 2 meant as "write" grants it to maintain.

References

Description

  • modules/org-ruleset/variables.tf: description now lists 2 (maintain), 4 (write), 5 (admin). The read/triage IDs are dropped because the provider documentation does not list them.
  • modules/org-ruleset/README.md: regenerated with terraform-docs.

🚨 To Reviewers

  • Validation:
    • Description-only change; no behavior change.
    • terraform fmt -check -recursive clean; terraform init -backend=false + terraform validate in modules/org-ruleset succeed.

Worktree: ~/.git-worktrees/tedilabs/terraform-github-modules/org-ruleset-repository-role-ids/

@github-actions github-actions Bot added the 💾 org-ruleset This issue or pull request is related to org-ruleset module. label Nov 20, 2026
@github-actions github-actions Bot added the size/XS Extra Small size issue or PR. label Nov 20, 2026
@github-actions

Copy link
Copy Markdown

Terraform Integration

Directory fmt validate tflint docs
modules/org-ruleset ✅ ✅ ✅ ✅

✅ All 1 passed.

@posquit0
posquit0 merged commit a7a36b7 into main Nov 20, 2026
7 checks passed
@posquit0
posquit0 deleted the fix/org-ruleset-repository-role-ids branch November 20, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💾 org-ruleset This issue or pull request is related to org-ruleset module. size/XS Extra Small size issue or PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant