Repository navigation
fix(org-ruleset): correct RepositoryRole bypass actor IDs in description - #56
Merged
Merged
Conversation
Terraform Integration
✅ All 1 passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
bypass_list.*.actor.iddescription inmodules/org-ruleset/variables.tf:36listed theRepositoryRoleIDs as1(maintain),2(write),3(admin),4(read),5(triage). The provider documentation gives a different mapping:maintain->2,write->4,admin->5(andOrganizationAdmin->1).5meant as "triage" actually grants bypass to admin, and2meant as "write" grants it to maintain.References
bypass_actorsDescription
modules/org-ruleset/variables.tf: description now lists2(maintain),4(write),5(admin). The read/triage IDs are dropped because the provider documentation does not list them.modules/org-ruleset/README.md: regenerated withterraform-docs.🚨 To Reviewers
terraform fmt -check -recursiveclean;terraform init -backend=false+terraform validateinmodules/org-rulesetsucceed.Worktree:
~/.git-worktrees/tedilabs/terraform-github-modules/org-ruleset-repository-role-ids/