Skip to content

Remove the temporary conventional-changelog-conventionalcommits override #339

Open

Description

@dhensby

package.json has an overrides entry, "conventional-changelog-conventionalcommits": ">= 8.0.0", which fa81dd9 ("ci: fix release process", June 2024) added as a temporary fix.

It now holds the preset at 8.0.0 for every package that uses it. @commitlint/config-conventional 21 asks for ^10.0.0 (the latest is 10.4.1), so commitlint runs with an older preset than it expects. .releaserc uses the conventionalcommits preset, but the repo doesn't depend on it directly: it is installed only because commitlint pulls it in.

Suggested fix:

  • Add conventional-changelog-conventionalcommits as a direct dev dependency, at a version that the semantic-release plugins support. In their own tests, @semantic-release/commit-analyzer 13.0.1 uses 8.0.0 and @semantic-release/release-notes-generator 14.1.1 uses 9.3.1.
  • Remove the override, so that commitlint gets the version it asks for.
  • Check commitlint on a few commits, and check the notes of the next real release. A preset change can change how commits are parsed and how the changelog looks.

I left this out of #338 to keep that PR to the release-path guards.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    dependenciesPull requests that update a dependency file

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions