Repository navigation
ci: check that the installed instance works in runaction - #344
Merged
Merged
Conversation
…over TCP When setup exits 0, the action only warns if the database doesn't become ready, and no step after it used the result. A change that broke the SA login or TCP would therefore leave CI green. Add a step after the action that logs in as sa over TCP with the sa-password output, retrying for about a minute. It checks that the instance-name output is MSSQLSERVER, that SQL Server reports the major version for the matrix entry and the default collation, and that the requested ODBC driver is registered. A failure here also uploads the SQL Server logs. The readiness check in the action uses `-S (local)`, which connects through shared memory, so it doesn't prove that TCP is enabled. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A failed cumulative update download is only a warning in the action, so a change that always skipped the update would leave CI green. After the login check, compare the level that SQL Server reports with install-updates. 2016 is updated with a service pack, so expect a level above SP2. The other versions are updated with a cumulative update, so expect a CU update level. Write a warning when they don't match, in either direction. It is only a warning, because a Microsoft download outage makes the action install without updates, and that shouldn't fail unrelated changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…out updates Every runaction job used the same inputs, so CI never ran the action with ODBC 18, with the readiness check turned off or with updates turned off. Add three jobs, each changing one input: ODBC 18 with SQL Server 2022 on windows-2025, wait-for-ready set to false with the latest version on windows-2025 (which also runs the reboot-requested path without the readiness check), and install-updates set to false with 2019 on windows-2022. A new matrix key, variant, is empty for the existing jobs, so each include entry adds a job instead of changing one, and the existing job names stay the same. The check step reads the same inputs, and the log artifact name includes the variant so that the names stay unique. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the second part of #326. The
runactionjobs ran the action, but nothing checked the result. When setup exits 0, the action only warns if the database doesn't become ready, and a failed cumulative update download is also only a warning. So a change that broke the SA login or TCP, or always skipped the update, left CI green.saover TCP (tcp:127.0.0.1,1433) with thesa-passwordoutput, and retries for about a minute. The action's own readiness check uses-S (local), which connects through shared memory, so it doesn't prove that TCP works. The step also checks thatinstance-nameisMSSQLSERVER, that SQL Server reports the expected major version for the matrix entry, that the collation is the default, and that the requested ODBC driver is registered. Any of these fails the job, and a failure still uploads the SQL Server logs.install-updates: a level above SP2 for 2016 (updated by a service pack), and a CU update level for the others. A mismatch in either direction is a warning, not a failure, because a Microsoft download outage makes the action install without updates.wait-for-ready: falsewith the latest version on windows-2025, which also covers the reboot-requested (3010) path without the readiness check; andinstall-updates: falsewith 2019 on windows-2022. Avariantmatrix key keeps them separate from the existing 12 jobs, whose names don't change. The log artifact name includes the variant.SQL Server 2008–2014 stay out of CI: GitHub no longer offers a runner image they support, and the README already says they need
skip-os-check.The step runs only on Windows, so this PR's own CI run is its first test.
Part of #326
🤖 Generated with Claude Code