Skip to content

ci: run the release on the Node.js LTS line and check the release tools on PRs - #347

Draft
dhensby wants to merge 3 commits into
tediousjs:masterfrom
dhensby:ci/release-node-lts
Draft

dhensby wants to merge 3 commits into
tediousjs:masterfrom
dhensby:ci/release-node-lts

Conversation

@dhensby

@dhensby dhensby commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

The release tools follow the Node.js LTS line, but the release job ran on the Node version in .nvmrc (24), which matches the action's node24 runtime. The next semantic-release major (#345) needs Node 26.13 or later, so it could never run there, and nothing showed that before a merge, because the release job runs only on master.

  • Release job on the latest LTS. The release job runs on lts/*, currently 26 (26.13.1). The version is set once, as RELEASE_NODE_VERSION at the top of the workflow. When a new LTS line starts, the check below moves with it and the release job waits for that check, so an incompatible release tool shows up as a failed check, not a broken release. The action, its tests and the other build checks still use .nvmrc. Every package in both lockfiles accepts Node 26.13.1.
  • Check the release tools on every change. A new Check release tools job installs tools/release on the release Node version and runs semantic-release --version. The semantic-release CLI exits with an error when the Node version doesn't meet its engines. I checked this locally: on Node 24, semantic-release 25.0.9 exits 0, and 26.0.1 exits 1 with node version >=26.13 is required. The job also rebuilds lib/ on the release Node version and fails if the result differs from the committed files, because semantic-release commits the build it makes there. The release job now waits for this job.

This doesn't make #345 or #346 mergeable yet. semantic-release 26.0.1 runs on a beta @semantic-release/core and loads a beta @semantic-release/commit-analyzer from it, and preset 10.x (#346) needs the beta @semantic-release/release-notes-generator 15. Both stay open until those are stable.

The action itself doesn't change, so this doesn't release.

🤖 Generated with Claude Code

dhensby and others added 3 commits November 20, 2026 21:42
The release job ran on the Node version in .nvmrc, which is 24 to match
the node24 runtime of the action. The release tools follow the Node.js
LTS line, and the next semantic-release major already needs Node 26.13
or later, so it could never run there.

Run the release job on Node 26, the current LTS line, set once at the
top of the workflow. Pin the major version so that a new LTS release
doesn't change the release job without a commit. The action itself,
its tests and its build checks still use .nvmrc. Every package in both
lockfiles accepts Node 26.13.1.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The release job runs only for pushes to master, so a change that broke
the release tools, such as a semantic-release update that needs a newer
Node version, passed every check and failed only at the next release.

Add a job that installs the release tools on the release Node version
and runs `semantic-release --version`, whose CLI exits with an error
when the Node version doesn't meet its engines. With semantic-release
26.0.1 on Node 24, it exits 1 with "node version >=26.13 is required".
The job also rebuilds lib/ on that Node version and fails if the result
differs from the committed files, because semantic-release commits the
build it makes there. The release job now waits for this job.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ci: run the release job on the latest Node.js LTS

The release job ran on the Node version in .nvmrc, which is 24 to match
the node24 runtime of the action. The release tools follow the Node.js
LTS line, and the next semantic-release major already needs Node 26.13
or later, so it could never run there.

Run the release job on the latest LTS (lts/*, currently 26), set once
at the top of the workflow. The action itself, its tests and its build
checks still use .nvmrc. Every package in both lockfiles accepts Node
26.13.1.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant