Repository navigation
Conversation
The release job ran on the Node version in .nvmrc, which is 24 to match the node24 runtime of the action. The release tools follow the Node.js LTS line, and the next semantic-release major already needs Node 26.13 or later, so it could never run there. Run the release job on Node 26, the current LTS line, set once at the top of the workflow. Pin the major version so that a new LTS release doesn't change the release job without a commit. The action itself, its tests and its build checks still use .nvmrc. Every package in both lockfiles accepts Node 26.13.1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The release job runs only for pushes to master, so a change that broke the release tools, such as a semantic-release update that needs a newer Node version, passed every check and failed only at the next release. Add a job that installs the release tools on the release Node version and runs `semantic-release --version`, whose CLI exits with an error when the Node version doesn't meet its engines. With semantic-release 26.0.1 on Node 24, it exits 1 with "node version >=26.13 is required". The job also rebuilds lib/ on that Node version and fails if the result differs from the committed files, because semantic-release commits the build it makes there. The release job now waits for this job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ci: run the release job on the latest Node.js LTS The release job ran on the Node version in .nvmrc, which is 24 to match the node24 runtime of the action. The release tools follow the Node.js LTS line, and the next semantic-release major already needs Node 26.13 or later, so it could never run there. Run the release job on the latest LTS (lts/*, currently 26), set once at the top of the workflow. The action itself, its tests and its build checks still use .nvmrc. Every package in both lockfiles accepts Node 26.13.1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release tools follow the Node.js LTS line, but the release job ran on the Node version in
.nvmrc(24), which matches the action'snode24runtime. The next semantic-release major (#345) needs Node 26.13 or later, so it could never run there, and nothing showed that before a merge, because the release job runs only onmaster.lts/*, currently 26 (26.13.1). The version is set once, asRELEASE_NODE_VERSIONat the top of the workflow. When a new LTS line starts, the check below moves with it and the release job waits for that check, so an incompatible release tool shows up as a failed check, not a broken release. The action, its tests and the other build checks still use.nvmrc. Every package in both lockfiles accepts Node 26.13.1.Check release toolsjob installstools/releaseon the release Node version and runssemantic-release --version. The semantic-release CLI exits with an error when the Node version doesn't meet its engines. I checked this locally: on Node 24, semantic-release 25.0.9 exits 0, and 26.0.1 exits 1 withnode version >=26.13 is required. The job also rebuildslib/on the release Node version and fails if the result differs from the committed files, because semantic-release commits the build it makes there. The release job now waits for this job.This doesn't make #345 or #346 mergeable yet. semantic-release 26.0.1 runs on a beta
@semantic-release/coreand loads a beta@semantic-release/commit-analyzerfrom it, and preset 10.x (#346) needs the beta@semantic-release/release-notes-generator15. Both stay open until those are stable.The action itself doesn't change, so this doesn't release.
🤖 Generated with Claude Code