Skip to content

Disable libzip's GnuTLS and MbedTLS backends in the vendored build - #61

Open
gdevenyi wants to merge 1 commit into
tee-ar-ex:mainfrom
gdevenyi:libzip-disable-tls-backends
Open

gdevenyi wants to merge 1 commit into
tee-ar-ex:mainfrom
gdevenyi:libzip-disable-tls-backends

Conversation

@gdevenyi

Copy link
Copy Markdown

Turns off libzip's GnuTLS and MbedTLS backends in the vendored build, next to the bzip2, LZMA, zstd and OpenSSL settings already there. TRX only uses deflate, so libzip needs no encryption.

Without this, on a host with libgnutls28-dev, the exported zip target links GnuTLS::GnuTLS and Nettle::Nettle. Consumers of that export set then fail to configure, for example find_package(ITK) with ITKTractographyTRX in the ANTs SuperBuild. Details in #60.

Fixes #60

Testing (Linux, GCC 15, GnuTLS 3.8.3 installed, -DTRX_BUILD_TESTS=ON):

main this PR
libzip crypto finds GnuTLS, links it none
GnuTLS in build.ninja yes no
Build and ctest — builds, 197/197 pass

The same two settings, applied in the ITK build, let ANTs configure, build and pass its tests with TractographyTRX on.

🤖 Generated with Claude Code

libzip enables its GnuTLS and MbedTLS crypto backends whenever it finds
them, so on a host with libgnutls28-dev the exported zip target links
GnuTLS::GnuTLS and Nettle::Nettle. Consumers that load that export set,
such as find_package(ITK) with ITKTractographyTRX, then fail to
configure because those targets are not defined. TRX only uses deflate,
so turn the backends off like the other optional libzip dependencies.

Fixes tee-ar-ex#60

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 19, 2026 15:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vendored libzip leaves GnuTLS/MbedTLS enabled, breaking find_package(ITK) consumers

2 participants