refactor(http): deprecate HeaderSessionIdResolver - #2280
Open
osbre wants to merge 1 commit into
Open
Conversation
Benchmark ResultsComparison of Open to see the benchmark results
Generated by phpbench against commit 78e317e |
Member
|
I agree that it might be broken at the moment, but isn't this important for async request? That being said, you could use cookies there as well. I actually don't remember why we ever added support for it. @innocenzi do you perhaps know? |
Member
|
Hey @brendt, this existed before I touched the session implementation. Honestly unsure about its use case, but you must have had one if you introduced it. Or maybe it was just an easy way of authenticating prior to having cookie-based auth? I'm fine with removing it unless we actually have a use case that justify its presence |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecates
HeaderSessionIdResolver, scheduled for removal in 4.0.Why
CookieSessionIdResolverprior to the first tagged release (v1.0.0-alpha.1).*_session_id), but request headers are normalized to hyphens by our own request layer (LaminasServerRequestFactory, after the SAPI collapses both forms toHTTP_..._..._), so the lookup can't match a client-supplied identifier. This is the unresolved half of BrokenHeaderSessionIdResolver#1892; fix(http): broken import in header session id resolver #1893 fixed the broken import but not the name mismatch.Given the above, deprecating and later removing it seems cleaner than investing further in fixing it. Happy to adjust if there's an intended use case I've missed.