feat(database): forward query builder methods to database models - #2285
Open
osbre wants to merge 2 commits into
Open
feat(database): forward query builder methods to database models#2285osbre wants to merge 2 commits into
osbre wants to merge 2 commits into
Conversation
Contributor
Author
|
Regarding the benchmark glitch: #2286 |
Member
|
Not something I am in favor of personally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces static select-side query builder methods to
IsDatabaseModel, removing the redundant::select()boilerplate when starting queries.Before
After
Changes
where,whereField,whereHas,orderBy,limit,with,join, and pagination helpers can now be called directly statically on models. Each forwarder is a direct delegation tostatic::select()->....HasWhereRelationMethods::whereHas()andwhereDoesntHave()annotations to ensure proper type inference for the forwarded methods.andWhere*,orWhere*) and internal SQL compilation utilities remain builder-only, since neither is meaningful as an opening call.Tests
No new tests were added. Every forwarded method is already exercised at the builder level in
tests/Integration/Database/, and the forwarders add no logic beyond method dispatch. This follows the existing convention of testing behaviour where the builder lives: thesum()andavg()statics are covered inAggregateQueryBuilderTest, notIsDatabaseModelTest.