Repository navigation
Fix split-table alignment for grouped subgroups (#40) - #41
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
thatoneguy006
force-pushed
the
codex/fix-40-subgroup-split-alignment
branch
from
October 22, 2026 22:02
23964bb to
9ec5ffa
Compare
thatoneguy006
added a commit
that referenced
this pull request
Oct 31, 2026
* Misc doc changes * Implement structured forest rows and table formatters * Fix grouped subgroup table alignment (#40) (#41) * Support point sizes mapped from data columns (#38) * Remove point size vignette addition * Support point sizes mapped from data columns (#38) (#42) * Support point sizes mapped from data columns (#38) * Fix shared layer mutation when adding scales and tables * Render forest rows consistently in top-to-bottom data order * Filter mixed-model tidies to conditional coefficients * Preserve supplied model order in legends and dodge * Reject unknown fitted-model arguments * Recognize quasibinomial effect scales * Clarify exponentiate semantics for models and data frames * Default forest data mappings to broom column names * Match legend titles to mapped group headers * Prune removed source columns while preserving metadata keys * Round numeric extra table columns by default * Document summary row geometry * Remove redundant hline aesthetic inheritance arguments * Normalize subgroup contrast labels across versions * Use population-level mixed-model subgroup effects * Set dependency floors and expand compatibility CI * Use a temporary null device for table measurement * Remove unreachable row construction fallbacks * Reject unsupported forest plot inputs clearly * Remove duplicate subgroup validation * Correct internal table width documentation * Clean section comments vignettes and stale submission metadata * Prepare 0.6.0 argument aliases and API consistency * Record independent change review and guard ordinary ggplot scales * Refresh issue forms release notes and CI triggers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40.
When
subgroupandgroupare both mapped, the centered and dodged text layers could train a split table's y scale in a different row order than the forest plot. Establish the complete visible row order with an invisible layer before drawing grouped table text, keeping estimates and subgroup p-values aligned with the forest plot. The shared table builder also fixes the same behavior in estimate-onlyadd_forest_table()layouts.Add numeric regression checks for estimates on either side, stripes, custom dodge widths, overall/level p-values, factor and character groups, sparse groups, free-y facets, and custom row selections. Add
vdiffrto Suggests and two reviewed SVG snapshots covering striped and faceted layouts.Validation:
R CMD buildandR CMD check --no-manual: Status: OK, including vignette builds and checks.vdiffrsnapshots.