Repository navigation
Support point sizes mapped from data columns (#38) - #42
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38.
ggforestplot(data, point_size = "N")now maps a numeric source column through ggplot2's size aesthetic instead of passing the column name as a literal marker size. Constant numeric sizes remain supported, and mapped sizes can be customized withscale_size_continuous()orscale_size_area().Preserve original source-column values and types when canonical normalization converts them to labels, so numeric
ncolumns can also drive marker sizes. Resolve original source names even when they collide with internal columns, and validate sizes only for estimate and summary rows. Missing columns and invalid size values now produce errors before rendering.Add API documentation, regression tests for sorting, facets, grouped subgroups, row filtering, fitted-model output, source-column collisions, and invalid inputs, plus a reviewed
vdiffrsnapshot of the split-table workflow from the issue.Validation:
R CMD buildandR CMD check --no-manual: Status: OK, including vignette builds and checks.