Skip to content

Support point sizes mapped from data columns (#38) - #42

Merged
thatoneguy006 merged 2 commits into
devfrom
codex/fix-38-point-size-column
Oct 22, 2026
Merged

thatoneguy006 merged 2 commits into
devfrom
codex/fix-38-point-size-column

Conversation

@thatoneguy006

@thatoneguy006 thatoneguy006 commented Oct 22, 2026 •

Copy link
Copy Markdown
Owner

Fixes #38.

ggforestplot(data, point_size = "N") now maps a numeric source column through ggplot2's size aesthetic instead of passing the column name as a literal marker size. Constant numeric sizes remain supported, and mapped sizes can be customized with scale_size_continuous() or scale_size_area().

Preserve original source-column values and types when canonical normalization converts them to labels, so numeric n columns can also drive marker sizes. Resolve original source names even when they collide with internal columns, and validate sizes only for estimate and summary rows. Missing columns and invalid size values now produce errors before rendering.

Add API documentation, regression tests for sorting, facets, grouped subgroups, row filtering, fitted-model output, source-column collisions, and invalid inputs, plus a reviewed vdiffr snapshot of the split-table workflow from the issue.

Validation:

  • R CMD build and R CMD check --no-manual: Status: OK, including vignette builds and checks.
  • Complete suite: 851 passed, 0 failures, 0 warnings, 0 skips, including the visual regression snapshots.
  • Visually inspected the split table with column-mapped marker sizes and its size legend.

@thatoneguy006
thatoneguy006 merged commit 19e8da0 into dev Oct 22, 2026
6 checks passed
@codecov

codecov Bot commented Oct 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@thatoneguy006
thatoneguy006 deleted the codex/fix-38-point-size-column branch October 23, 2026 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant