Repository navigation
audio: kpb: stream handling fixes - #11446
Merged
Merged
Conversation
Treat an unbound drain sink as a valid notification-only configuration while preserving errors for bound but inactive sinks. Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
Return PPL_STATUS_PATH_STOP only when the realtime sink has no pending data, allowing downstream modules to consume newly produced or queued audio. Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
Handle source ring-buffer wraparound when reading selected microphone channels. Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the KPB stream-handling changes.
No open issues 🎉
What changed in this PR
This PR fixes Keyword Processing Buffer (KPB) stream handling for detection-only configurations and realtime audio processing.
Changes:
- Ignore drain requests when no drain sink is connected.
- Allow downstream processing to continue when the realtime sink has audio available.
- Handle input ring-buffer wraparound when copying selected microphone channels in both optimized and generic implementations.
| File | Description |
|---|---|
src/audio/kpb.c |
Fixes optional drain-sink handling, realtime path continuation, and microphone-selection input wraparound. |
Review effort: Balanced
PR 11446: test resultsRun date: 2026-11-12 19:17 UTC Tested commit: c2a4781ec4e516210afc283f608104e1c00c417c
|
lgirdwood
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle detection-only configurations without a drain sink and keep the realtime path running when audio is available. Handle ring-buffer wraparound when copying selected microphone channels.