Repository navigation
Replace legacy WebSocket dependency with bounded Node transport - #1
Open
mswilkison wants to merge 1 commit into
Open
mswilkison wants to merge 1 commit into
mswilkison wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The locked
websocket@1.0.29transport brings a large, obsolete runtime tree into every Node consumer. Replace it with a small event adapter over native browser WebSocket and pinnedws@8.22.1in Node, reducing required production lock entries from 387 to 1. Remove the unused npmfssecurity-placeholder package and regenerate the lockfile.Node retains a maintained protocol implementation because native Node WebSocket cannot express the existing HTTP/TLS request options or configure a pre-assembly receive limit. The adapter preserves custom CA/certificate/key/header/agent options, disables compression, and fixes an 8 MiB aggregate message limit even when callers supply overriding transport options. WebSocket framing and cryptography are not implemented locally. Failed connections reset their status so consumers can retry; late events from replaced sockets are ignored.
Compatibility changes:
Validation:
npm ci --ignore-scripts, andgit diff --checkpass.npm packplus a clean production-only consumer import/constructor smoke check pass; test TLS fixtures are excluded from the published package.npm run test:integrationand manual CI dispatch.A full browser bundle and live public Electrum integration were not run. Existing development-tool dependencies are outside this focused reduction; this is not a claim that the entire repository is vulnerability-free.