Repository navigation
feat: docctl: review/approve on behalf of a signer without git - #24
Merged
Merged
Conversation
tobiaskaestner
requested changes
Oct 31, 2026
tobiaskaestner
left a comment
tobiaskaestner
left a comment
Contributor
There was a problem hiding this comment.
Co-Pilot found one medium security flaw, please take a look again.
Add --user/--email to docctl review and approve for reviewers and approvers who only sign the PDF and don't use git. The given name/email (each falling back to git config if only one is given) is stamped into the doc_control directive instead of the git identity, and the segregation-of-duties check applies to that stamped person. The commit is still signed off and GPG-signed by the git user doing the work. Its body states the entry was recorded on behalf of the stamped person, who authorized it, and that the signature on the archived PDF is the evidence of record; the Reviewed-by/Approved-by trailer names that person. Without the options, commits are unchanged. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
volker-kempert
force-pushed
the
feature/vrkt/docctl-cmd-update
branch
from
November 2, 2026 11:15
19af6d0 to
53a4f2d
Compare
tobiaskaestner
self-requested a review
November 2, 2026 12:52
tobiaskaestner
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add --user/--email to docctl review and approve for reviewers and approvers who only sign the PDF and don't use git. The given name/email (each falling back to git config if only one is given) is stamped into the doc_control directive instead of the git identity, and the segregation-of-duties check applies to that stamped person.
The commit is still signed off and GPG-signed by the git user doing the work. Its body states the entry was recorded on behalf of the stamped person, who authorized it, and that the signature on the archived PDF is the evidence of record; the Reviewed-by/Approved-by trailer names that person. Without the options, commits are unchanged.