docs: update README - #39
Open
ktro2828 wants to merge 1 commit into
Open
Conversation
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
manato
reviewed
Sep 3, 2026
manato
left a comment
manato
left a comment
Collaborator
There was a problem hiding this comment.
@ktro2828
I highly appreciate your this PR to make the top README follow the current structure! (And so sorry for the delay in my reviewing 🙇 )
Entirely, it looks great. I left small comments to the places where I noticed. Considering them would be appreciated!
| git clone https://github.com/tier4/accelerated_image_processor.git | ||
| cd accelerated_image_processor | ||
|
|
||
| ## Camera Intrinsics Publication |
Collaborator
There was a problem hiding this comment.
Would you mind moving this camera-info related notes to somewhere, such as README of accelerated_image_processor_ros or accelerated_image_processor_pipeline for future reference?
| cd ~/ros2_ws/src | ||
| git clone https://github.com/tier4/accelerated_image_processor.git | ||
| ``` | ||
| | Package | Role | ROS dependency | |
Collaborator
There was a problem hiding this comment.
[Super nit] adding links to the READMEs for each pacakge would be great!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Related Links
Description
This pull request updates README.
Review Procedure
Remarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks