Repository navigation
compiler: remove invalid pragmas from test fixture - #5894
Merged
Merged
Conversation
Both pragmas are ignored in these positions. Remove them before adding stricter pragma checks. The expected LLVM IR is unchanged.
jakebailey
reviewed
Oct 16, 2026
|
|
||
| // The //go:noescape pragma only works on declarations, not definitions. | ||
| // | ||
| //go:noescape |
Member
There was a problem hiding this comment.
I'm confused, why does this have to be removed? (Not that I know why this was there in the first place)
Contributor
Author
There was a problem hiding this comment.
I have a PR coming which will validate pragmas better; it started from the //go:nolinktime PR, but I spotted that other pragmas could validate their arguments sooner and spot invalid use rather than silently being ignored
Contributor
Author
|
@deadprogram PTAL, this is related to #5887 and is a prerequisite for adding better validation of pragmas. I'm doing the cleanups now because I don't want to mix the fixups with the compiler change and keep the change smaller. |
deadprogram
approved these changes
Oct 19, 2026
deadprogram
left a comment
deadprogram
left a comment
Member
There was a problem hiding this comment.
Thanks for the fix @davecheney and to @jakebailey for review. Now merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both pragmas are ignored in these positions. Remove them before adding stricter pragma checks. The expected LLVM IR is unchanged.