[rdon-key]

Fixes #5896.

Extend TestBuild/EmulatedRISCV to run with both the cores and tasks schedulers.

Previously, only the default cores scheduler was tested.

Changes

• Run EmulatedRISCV tests separately with cores and tasks.
• Update the goroutines.go test exclusion to use the effective scheduler, respecting options.Scheduler when explicitly specified.
• Preserve the existing scheduler-specific test exclusions.

Testing

Tested on Windows 11 with QEMU 11.1.0 and LLVM 22.1.4.

make test GOTESTPKGS=. \
  GOTESTFLAGS="-run '^TestBuild/EmulatedRISCV' -count=1 -v"

All tests passed with both schedulers.

• cores: PASS
• tasks: PASS (including goroutines.go)
• Total execution time: 43 seconds

[dgryski]

In principle this is fine but our CI servers are already pretty overloaded. I'd like to hear from @deadprogram first before approving this.

[jakebailey]

I thought it was just macOS that was overloaded? I think adding more parallel Linux jobs does generally work?

[deadprogram]

I thought it was just macOS that was overloaded? I think adding more parallel Linux jobs does generally work?

macOS is the most overloaded, but nearly all runners get queued these days. We are getting too much done! 😛

[deadprogram]

Thanks for working on this @rdon-key! I ran the tests on my local machine and looked it over. The following is edited from an automated review:

1. Since this branch was made, dev added a coreassign.go test with a skip that still uses spec.Scheduler. The branch merges cleanly, but after the merge TestBuild/EmulatedRISCV/tasks/coreassign.go fails because the skip sees cores from the target spec:

   -second AssignCore panics: true
   +second AssignCore panics: false
   

   Please rebase on dev and change that check to use the new scheduler variable too:

   if name == "coreassign.go" && scheduler != "cores" {

   With that change, all of TestBuild/EmulatedRISCV passes for me with both schedulers.

What do you think of this?

[rdon-key]

Thanks for catching this, Ron.

You're right, I missed the new coreassign.go test added to dev.
I've rebased onto dev and updated the coreassign.go skip condition to use the effective scheduler.
I reran TestBuild/EmulatedRISCV locally. All tests passed with both cores and tasks, including coreassign.go under cores.

Thanks for testing this on your side as well!