Repository navigation
interp: find TestInterp cases with a glob - #5916
Merged
Merged
Conversation
TestInterp used a list of test names in interp_test.go. Each new IR test had to add its name to this list. Branches that each added a name at the end of the list had merge conflicts with each other. Each test case is a pair of files, testdata/<name>.ll and testdata/<name>.out.ll. TestInterp now finds the cases with a glob on testdata/*.out.ll. A new case does not need a change to interp_test.go. The test fails if the glob finds no files. largearray.ll has no .out.ll file, thus TestInterp does not use it. TestInterpLargeArray continues to use it.
Member
|
Thanks @davecheney and @dgryski now merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestInterp used a list of test names in interp_test.go. Each new
IR test had to add its name to this list. Branches that each added a
name at the end of the list had merge conflicts with each other.
Each test case is a pair of files, testdata/.ll and
testdata/.out.ll. TestInterp now finds the cases with a glob
on testdata/*.out.ll. A new case does not need a change to
interp_test.go. The test fails if the glob finds no files.
largearray.ll has no .out.ll file, thus TestInterp does not use it.
TestInterpLargeArray continues to use it.