Repository navigation
tests: count string comparison allocations with any garbage collector - #5938
Merged
deadprogram merged 1 commit intoOct 21, 2026
Merged
Conversation
The test read exact byte counts from runtime.MemStats, so it needed the conservative collector, and a change in how that collector counts bytes could break it, as deadprogram said in tinygo-org#5784 (comment). testing.AllocsPerRun gives the same count with every collector, so the test can also run with the default collector of each target, which is boehm on hosts.
deadprogram
reviewed
Oct 21, 2026
deadprogram
left a comment
deadprogram
left a comment
Member
There was a problem hiding this comment.
Good stuff @davecheney thank you very much! Now merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test read exact byte counts from runtime.MemStats, so it needed the conservative collector, and a change in how that collector counts bytes could break it, as @deadprogram said in #5784 (comment).
testing.AllocsPerRun gives the same count with every collector, so the test can also run with the default collector of each target, which is boehm on hosts.