Repository navigation
feat(lemula): replace partner banners with Lemula house ads (BLD-502) - #25
Merged
Merged
Conversation
The editor strip, example pages and the About page showed Preply, Railway, Cursor and Wise. They now show Lemula banners from the set prepared in BLD-501, copied verbatim into lib/components/lemula. - Editor strip: a calm card next to a bold one, the next pair every UTC hour; one calm card on narrow screens. Collapsed, it shows the `bar` block beside the expand button. "Partner offers" is gone. - Example pages and About: the `feature` block. About's "Partner links" section becomes "Lemula". - Clicks report the existing `affiliate_click` event with partner "lemula" and the block name as product. The banner CSS is imported as a global stylesheet, since Svelte's scoping would strip the plain-HTML blocks of their styles; Vite bundles it with the fonts. The partner components, rotation and "why is this here" tooltip are removed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
`npm audit fix` without breaking changes, so the high-level CI audit passes again: vite 8.0.16 -> 8.3.7 (with rolldown), @sveltejs/kit 2.70.4, vite-plugin-svelte 7.3.1, eslint 10.14, typescript-eslint 8.72 and transitive bumps. SvelteKit advisories that need kit 3 remain; they are below the CI threshold. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
`npm audit fix` (npm 11.19) removed flowbite-datepicker's nested flowbite@2.5.2, leaving a lock file `npm ci` rejects. `npm install` puts it back; `npm ci --dry-run` passes on npm 10 and 11. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The partner banners (Preply, Railway, Cursor, Wise) are replaced with Lemula house ads from the set prepared in BLD-501 (
marketing/aligner-banners/in the Lemula repo).card-history+bold-sentence,card-glossed+bold-morph,card-compound+bold-tree,card-borrowing+bold-rule). The next pair shows every UTC hour; the home page is server-rendered per request, so it rotates. Narrow screens show the calm card only. Collapsed, the strip shows thebarblock beside the expand button. The "Partner offers" label is gone, and the strip is now an<aside aria-label="Lemula banners">.featureblock. About's "Partner links" section becomes "Lemula" with a one-line intro.affiliate-link,data-partner="lemula"anddata-product=<block>when rendered, so the existingaffiliate_clickGA event reports it. The links keep their UTM tags for Lemula's analytics.How the assets are wired
lib/components/lemula/holds the blocks, CSS and fonts copied verbatim (excluded from prettier, so a later update is a copy).LemulaBlockimports the CSS as a global stylesheet (Svelte's scoping would strip the plain-HTML blocks of their styles) and renders the block markup. Vite bundles the CSS and hashes the fonts; the mono font loads only on cards that use it.Dependencies
The CI audit failed on a new high advisory in vite.
npm audit fixwithout breaking changes: vite 8.0.16 → 8.3.7 (with rolldown), @sveltejs/kit 2.70.4, vite-plugin-svelte 7.3.1, eslint 10.14, typescript-eslint 8.72. npm 11.19 dropped a nestedflowbite@2.5.2from the lock file, whichnpm cirejected;npm installrestored it, andnpm ci --dry-runpasses on npm 10 and 11. SvelteKit advisories that need kit 3 remain, below the CI threshold.On the updated dependencies, a local production build matches prod for all 22 gallery renders and 20 of 22 editor examples; the other two are Japanese examples whose CJK web font loads at different times (each matched prod on a rerun).
Verification
Local dev server and production build, headless Chromium:
barwith the expand button; clicking the bar opens Lemula and reportsaffiliate_click(partner: lemula,product: bar); clicking a card reports its block name.featureat 720×311, light and dark.svelte-check, prettier, eslint, vitest (213) andvite buildare clean.Not changed
/termsstill says the tool "may show partner or affiliate links". It is worded as a possibility, so it stays accurate.docs/partner-affiliate-portable-spec.mdstill describes the partner banner system.🤖 Generated with Claude Code