set red power cap via power-limit instead of amd-smi - #9
Open
teddytennant wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
amd-smi set --power-captook one argument through ROCm 7.1 and takes two from 7.2. Inamdsmi_cli/amdsmi_parser.pyit went fromaction='store', metavar='WATTS'(7.1.0:1283) tonargs=2, metavar=('PWR_TYPE','WATTS')(7.2.0:1362), which is whereexpected 2 argumentscomes from. 6.4.0 and 7.0.0 both carry the old shape, so the break lands exactly at 7.2, and02install-drivers.shnow installs SDK 7.14, which has the new one.Rather than track the amd-smi CLI, this points the unit at
tools/power-limit, which already sets the red cap by writingpower1_capdirectly and validates againstpower1_cap_min/power1_cap_max.11symlink.sh:10symlinks it to/usr/local/bin/power-limitinside the same[[ -z "$TINYBOX_CORE" ]]branch that installs this unit, and00release.shwrites/etc/tinybox-releaseinpre.dbeforepost.druns, so both exist by the time the unit fires.One behaviour change worth flagging:
power-limitrejects an out-of-range value and exits 1, whereamd-smi set -o 304did not validate. On a card whosepower1_cap_maxis under 304 that turns a silent no-op into a failed oneshot.I don't have a red box, so this is verified by reading the build scripts, not by booting an image.
Closes #5.