Repository navigation
feat(alert-dialog): 取り消せない操作の前に確かめる AlertDialog を追加する - #32
Merged
Merged
Conversation
- Base UI の AlertDialog。見出しは対象を入れた問いかけ、ボタンは「キャンセル」と動詞 - 開くとフォーカスをキャンセルに置き、外側を押しても閉じない - onConfirm が Promise なら終わるまで処理中にして閉じない。例外なら開いたまま - DESIGN.md・04 の部品の選び方・README に追加し、バックログから外した bouzu(tkc310/bouzu#73)の削除確認の文言と流れを反映。 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01S5dPLGGVzZyRz8dob3cTmz
tkc310
pushed a commit
that referenced
this pull request
Nov 7, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01S5dPLGGVzZyRz8dob3cTmz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by tkc310 · project thread
変更内容
バックログにあった AlertDialog(取り消せない操作の確認)を追加します。bouzu(tkc310/bouzu#73)で読誦セットの削除に確認を足したとき、8341-ui に確認の部品が無く、文言と流れを画面ごとに書いていました。
role="alertdialog")。見出しは対象を入れた問いかけ、説明は結果、ボタンは「キャンセル」と動詞(confirmLabelは必須)tone:danger(既定)/primary(送信・公開など失うものが無い確認)onConfirmが Promise を返すと、終わるまで実行ボタンをloadingにして閉じない(Esc でも閉じない)。例外を投げると開いたままにし、失敗はchildrenに NotificationBanner で出せるStorybook プレビュー
プレビュー: https://tkc310.github.io/8341-ui/pr-preview/pr-32/ (5422f36 時点)
エージェントは 390px 幅のライト(Failure)とダーク(Primary)を Playwright で描画して確かめました。
完了の定義
make checkとmake testが通る(ストーリーの play 関数と axe を含む).changeset/alert-dialog.md。docs/releasing.md の 0.x の規則で部品の追加は patch)改善ループ
docs/improvement/log.mdに 1 行追記したhttps://claude.ai/code/session_01S5dPLGGVzZyRz8dob3cTmz
Generated by Claude Code