Repository navigation
fix(mc): install mc from the pgsty community fork - #22
Merged
Merged
Conversation
The feature downloads https://dl.min.io/client/mc/release/linux-amd64/mc, which answers `410 Gone`: MinIO Inc. archived the community edition and withdrew its free binaries and images in September 2026, so every devcontainer build using this feature fails. The URL was also amd64-only, so arm64 containers got an unusable binary. pgsty/mc is the maintained community fork. The feature installs its release tarball for the container's architecture (amd64 or arm64), pinned and SHA-256 verified so a changed upstream artifact fails the build instead of shipping. The fork names the binary `mcli`; it is installed as `mc` so existing callers keep working. https://github.com/pgsty/mc/releases/tag/RELEASE.2026-09-16T00-00-00Z
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Dependency installation can omit CA certificates when curl is already present, causing HTTPS downloads to fail.
Review effort: Balanced
Findings: 1
What changed in this PR
Updates the mc feature to install the architecture-specific pgsty community fork with checksum verification.
Changes:
- Pins and verifies pgsty
mcli, installing it asmc. - Adds amd64 and arm64 support.
- Bumps the feature version to 1.1.0 and updates documentation.
| File | Description |
|---|---|
src/mc/NOTES.md |
Documents the fork and upgrade process. |
src/mc/install.sh |
Downloads and verifies architecture-specific binaries. |
src/mc/devcontainer-feature.json |
Updates metadata and version. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+18
to
21
| if ! command -v curl >/dev/null 2>&1; then | ||
| apt-get update | ||
| apt-get install -y --no-install-recommends wget ca-certificates | ||
| apt-get install -y --no-install-recommends curl ca-certificates | ||
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Every devcontainer build that uses
ghcr.io/tmaier/devcontainer-features/mcfails: the feature downloadshttps://dl.min.io/client/mc/release/linux-amd64/mc, which answers410 Gone. MinIO Inc. archived the community edition and withdrew its free binaries and images in September 2026. The hard-coded URL was also amd64-only, so arm64 containers got an unusable binary.What changes
mcfrom pgsty/mc, the maintained community fork, using the release tarball for the container's architecture (amd64orarm64).RELEASE.2026-09-16T00-00-00Zand verifies its SHA-256, so a changed upstream artifact fails the build instead of shipping.mclibinary asmc, so existing callers keep working.1.1.0.Verified
devcontainer features test --skip-scenarios -f mcpasses ondebian:latestandubuntu:latest, and themc_testscenario passes, all on arm64. CI covers amd64.mc alias set/mb/rbcalls work against a MinIO server.After merge, the release workflow (manual
workflow_dispatch) needs to run to publish1.1.0to GHCR.