Fix samples - #100
Open
wellingtoncosta wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the CrashKiOS sample projects to build/align with newer tooling and iOS/Gradle integration settings, and refreshes sample dependencies/configuration.
Changes:
- Update sample Gradle wrappers and tidy shared module Gradle scripts.
- Adjust CocoaPods integration (including xcconfig) and refresh Podfile.lock metadata.
- Update sample dependency wiring (Bugsnag link plugin substitution) and include Firebase config in the Crashlytics sample.
Reviewed changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| samples/sample-crashlytics/shared/shared.podspec | Adds xcconfig override (disables user script sandboxing) and fixes formatting. |
| samples/sample-crashlytics/shared/build.gradle.kts | Removes KotlinCompile JVM target task configuration. |
| samples/sample-crashlytics/ios/Podfile.lock | Updates checksums and recorded CocoaPods version. |
| samples/sample-crashlytics/gradle/wrapper/gradle-wrapper.properties | Bumps Gradle wrapper version for the Crashlytics sample. |
| samples/sample-crashlytics/gradle/libs.versions.toml | Removes crashkios-utils coordinates from the sample version catalog. |
| samples/sample-crashlytics/build.gradle.kts | Removes crashkios-utils buildscript classpath entry and normalizes formatting. |
| samples/sample-crashlytics/app/google-services.json | Adds Firebase configuration (includes an API key and project identifiers). |
| samples/sample-crashlytics/app/.gitignore | Stops ignoring google-services.json (so it can be committed). |
| samples/sample-bugsnag/shared/shared.podspec | Adds xcconfig override (disables user script sandboxing). |
| samples/sample-bugsnag/shared/build.gradle.kts | Removes KotlinCompile JVM target task configuration. |
| samples/sample-bugsnag/settings.gradle.kts | Adds composite-build substitution for the Bugsnag link Gradle plugin marker module. |
| samples/sample-bugsnag/gradle/wrapper/gradle-wrapper.properties | Bumps Gradle wrapper version for the Bugsnag sample. |
| samples/sample-bugsnag/CrashKiOSSampleIOS/Podfile.lock | Updates checksums and recorded CocoaPods version. |
Suppressed comments (1)
samples/sample-crashlytics/app/.gitignore:2
- Removing google-services.json from .gitignore means the Firebase config (including API key and project identifiers) will be tracked/committed by default. If the intent is to keep credentials/project bindings out of the repo, restore this ignore entry and provide setup instructions or a sample template file instead.
/build
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.